updated expected kernel version test value to 4.14.186

[zenmonkeykstop]

Status

Ready for review

Description of Changes

Towards #546 .

Updates buster kernel version in tests from 4.14.169 to 4.14.186

• Kernel config changes: updated securedrop-workstation config for 4.14.182 build ansible-role-grsecurity-build#58
• Metapackage changes: Bumped workstation-grsec kernel version to 4.14.182 securedrop-builder#174

Testing

• Install workstation using this branch
• make test tests fail due to version mismatch
• Update kernel to 4.14.186 in securedrop-workstation-buster using packages from added 4.14.182 workstation kernel packages securedrop-apt-test#42
• run make clean and make all to rebuild workstation
• make test tests that check kernel version now pass

Checklist

If you have made code changes

• Linter (make flake8) passes in the development environment (this box may
  be left unchecked, as flake8 also runs in CI)

If you have made changes to the provisioning logic

• All tests (make test) pass in dom0 of a Qubes install

• This PR adds/removes files, and includes required updates to the packaging
  logic in MANIFEST.in and rpm-build/SPECS/securedrop-workstation-dom0-config.spec

[emkll]

Packages are now live on apt-test, so this should be good for final review

[eloquence]

I updated my staging environment just after the kernel packages landed, and make test is currently failing for me as a result due to expected kernel version mismatch. Will quickly make clone this branch to see if that resolves.

[eloquence]

Yep, this PR resolves the kernel version check failures for me. I get other test failures, mainly it seems because make test is not clever(?) enough to look in /usr/share/securedrop-workstation-dom0-config for config that was provisioned via securedrop-admin.

[eloquence]

And, after copying config.json and sd-journalist.sec into place where it's looking for them, I only get two unrelated test failures, test_log_dirs_properly_named and test_do_not_open_here. The first of these appears to be due to the existence of a host dir in sd-log; the second is due to black formatter changes in master relative to my staging env.

[conorsch]

The first of these appears to be due to the existence of a host dir in sd-log

Sounds like we have a flaky test, see similar report in #563 (comment) .

[sssoleileraaa]

lgtm

• Install workstation using this branch
• make test tests fail due to version mismatch

I saw assert kernel_version == EXPECTED_KERNEL_VERSION fail

- [ ] Update kernel to 4.14.186 in securedrop-workstation-buster using packages from freedomofpress/securedrop-apt-test#42

This step was done for me since by the time I got to this step the lfs pr was merged with the new kernel package

• make test tests that check kernel version now pass

I saw assert kernel_version == EXPECTED_KERNEL_VERSION no longer fail

[conorsch]

Test plan checks out. I did encounter one failing test, as described in #583, unrelated to the changes here.