Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
make test
tests fail due to version mismatchI saw
assert kernel_version == EXPECTED_KERNEL_VERSION
fail- [ ] Update kernel to 4.14.186 insecuredrop-workstation-buster
using packages from freedomofpress/securedrop-apt-test#42This step was done for me since by the time I got to this step the lfs pr was merged with the new kernel package
make test
tests that check kernel version now passI saw
assert kernel_version == EXPECTED_KERNEL_VERSION
no longer fail