Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sd-viewer MIME type test for mp4 audio #665

Merged
merged 1 commit into from Mar 16, 2021
Merged

Update sd-viewer MIME type test for mp4 audio #665

merged 1 commit into from Mar 16, 2021

Conversation

eloquence
Copy link
Member

@eloquence eloquence commented Mar 12, 2021 •
edited by emkll

Status

Ready for review, dependent on freedomofpress/securedrop-builder#224 and should be reviewed together.

Description of Changes

Resolves #664

Test plan

@eloquence eloquence mentioned this pull request Mar 12, 2021
Merged
2 tasks
@eloquence eloquence changed the title Update sd-viewer MIME type test for mp4 Update sd-viewer MIME type test for mp4 audio Mar 12, 2021
@eloquence eloquence added this to Ready for Review in SecureDrop Team Board Mar 15, 2021
@conorsch conorsch requested review from emkll and conorsch March 15, 2021 20:32
@emkll emkll moved this from Ready for Review to Under Review in SecureDrop Team Board Mar 16, 2021
@emkll emkll moved this from Under Review to Ready for Review in SecureDrop Team Board Mar 16, 2021
emkll
emkll approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests are passing with the 20200316 nightlies

@emkll emkll merged commit d6ae7bf into main Mar 16, 2021
SecureDrop Team Board automation moved this from Ready for Review to Done Mar 16, 2021
@emkll emkll deleted the add-mp4 branch March 16, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emkll emkll emkll approved these changes

@conorsch conorsch Awaiting requested review from conorsch

Assignees
No one assigned
Labels
None yet
Projects
No open projects
SecureDrop Team Board
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add M4A support
2 participants
@eloquence @emkll