Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add m4a (audio/mp4) to allow-list for sd-viewer #224

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Add m4a (audio/mp4) to allow-list for sd-viewer #224

merged 1 commit into from
Mar 15, 2021

Conversation

eloquence
Copy link
Member

@eloquence eloquence commented Mar 12, 2021 •
edited by emkll
Loading

M4A files use a different MIME type than MP3 and therefore currently will just silently exit out.

Resolves freedomofpress/securedrop-workstation#664

Test plan

  1. Download https://filesamples.com/samples/audio/m4a/sample1.m4a and upload to your SD instance
  2. Sync with SD Client on Qubes and attempt to play
  3. Observe failure
  4. Build package from this branch & install in sd-large-buster-template; shut down template
  5. Repeat step 2
  6. Profit!!!1 Observe that M4A file now plays as expected
  7. Review Update sd-viewer MIME type test for mp4 audio securedrop-workstation#665 for updated test

@eloquence eloquence added this to Ready for Review in SecureDrop Team Board Mar 12, 2021
@eloquence eloquence mentioned this pull request Mar 12, 2021
Merged
1 task
emkll
emkll approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed test plan is passing, Nightly builds should update existing dev instances.

@emkll emkll merged commit fe98653 into main Mar 15, 2021
SecureDrop Team Board automation moved this from Ready for Review to Done Mar 15, 2021
@emkll emkll deleted the add-mp4 branch March 15, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emkll emkll emkll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
SecureDrop Team Board
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add M4A support
2 participants
@eloquence @emkll