Have ./qa-switch.sh nightly switch to the nightlies apt component
#762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in <freedomofpress/securedrop-builder#289>, we want to move nightlies into their own component so they don't interfere with manually created release candidate packages. This only requires a different source.list line, so teach qa-switch how to enable it.
| - name: "deb [arch=amd64] https://apt.freedom.press buster main" | ||
| - name: "deb [arch=amd64] https://apt-test.freedom.press buster main" | ||
|
|
||
| add-test-apt-repo: |
There was a problem hiding this comment.
would be nice to also have an add-qa-apt-repo
|
Just a reminder that this change will also require a docs update |
Closed
|
@legoktm, let me know if you'd like to pair on this tomorrow or early next week, since I'll be picking this up once merged in order to QA nightlies on a fresh Qubes 4.1 installation. |
|
Would you be able to add support for switching to bullseye nightlies in this PR? |
|
Superseded by #783 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Work in progress
Description of Changes
As discussed in freedomofpress/securedrop-builder#289,
we want to move nightlies into their own component so they don't
interfere with manually created release candidate packages. This only
requires a different source.list line, so teach qa-switch how to
enable it.
Towards #600
Testing
qa-switch.sh, observe it maintains current behavior.qa-switch.sh nightly, observe it switches to nightly packagesDeployment
Any special considerations for deployment? Consider both:
Checklist
If you have made changes to the provisioning logic
make test) pass indom0If you have added or removed files
MANIFEST.inandrpm-build/SPECS/securedrop-workstation-dom0-config.specIf documentation is required