Merge pull request #5977 from freedomofpress/update-mypy-python-version

Update mypy configuration for Python 3.8
freedomofpress · Jun 9, 2021 · 1a80ef5 · 1a80ef5
2 parents 3d46171 + b123c09
commit 1a80ef5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/Makefile b/Makefile
@@ -114,7 +114,6 @@ shellcheckclean:  ## Clean up temporary container associated with shellcheck tar
 typelint:  ## Run mypy type linting.
 	@echo "███ Running mypy type checking..."
 	@mypy ./securedrop ./admin
-	@mypy --disallow-incomplete-defs --disallow-untyped-defs ./securedrop/rm.py
 	@echo
 
 .PHONY: yamllint

diff --git a/mypy.ini b/mypy.ini
@@ -2,7 +2,8 @@
 ignore_missing_imports = True
 no_implicit_optional = True
 disallow_untyped_defs = True
-python_version = 3.5
+disallow_incomplete_defs = True
+python_version = 3.8
 
 [mypy-tests.*]
 disallow_untyped_defs = False
diff --git a/securedrop/tests/utils/db_helper.py b/securedrop/tests/utils/db_helper.py
@@ -207,7 +207,7 @@ def new_codename(client, session):
     return codename
 
 
-def bulk_setup_for_seen_only(journo) -> List[Dict]:
+def bulk_setup_for_seen_only(journo: Journalist) -> List[Dict]:
     """
     Create some sources with some seen submissions that are not marked as 'downloaded' in the
     database and some seen replies from journo.