Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mypy configuration for Python 3.8 #5977

Merged
merged 1 commit into from Jun 9, 2021

Conversation

rmol
Copy link
Contributor

@rmol rmol commented Jun 7, 2021

Status

Ready for review

Description of Changes

Updates our mypy configuration to expect Python 3.8. We have dependencies using variable annotation syntax, causing Variable annotation syntax is only supported in Python 3.6 and greater errors from make typelint.

Also remove special-case linting of securedrop/rm.py.

Testing

  • make typelint should report no issues found.

Deployment

Dev only.

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make test) pass in the development container

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

Choose one of the following:

  • I have opened a PR in the docs repo for these changes, or will do so later
  • I would appreciate help with the documentation
  • These changes do not require documentation

@rmol rmol requested a review from a team as a code owner June 7, 2021 15:58
@eloquence eloquence added this to Ready for Review in SecureDrop Team Board Jun 7, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #5977 (b123c09) into develop (59da5b7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5977   +/-   ##
========================================
  Coverage    85.32%   85.32%           
========================================
  Files           53       53           
  Lines         3883     3883           
  Branches       481      481           
========================================
  Hits          3313     3313           
  Misses         457      457           
  Partials       113      113           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59da5b7...b123c09. Read the comment docs.

Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, other broken PRs will need a rebase after this is merged.

@kushaldas kushaldas merged commit 1a80ef5 into develop Jun 9, 2021
SecureDrop Team Board automation moved this from Ready for Review to Done Jun 9, 2021
@kushaldas kushaldas deleted the update-mypy-python-version branch June 9, 2021 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants