Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination #2067

Open
redshiftzero opened this issue Aug 3, 2017 · 4 comments
Open

Pagination #2067

redshiftzero opened this issue Aug 3, 2017 · 4 comments
Labels
app feature

Comments

@redshiftzero
Copy link
Contributor

Description

Currently, we have no pagination on results on either the SecureDrop source or journalist interface. For example, this means that if a news organization isn't great about deleting sources then they will have a list of potentially hundreds of sources appear whenever they load the journalist interface. This is bad for usability as it is overwhelming and it increases page load times, which are already slow due to Tor.

User Stories

As a journalist user, I want to see only the N most recent sources on the index so that I'm not overwhelmed with hundreds of sources.
@redshiftzero redshiftzero mentioned this issue Aug 3, 2017
Open
@heartsucker
Copy link
Contributor

When JS is enabled, we should flag it like ?js=1 so that we can send all the results and do pagination / sorting in the UI. Otherwise we use the backend to do this. I mean, assuming we want to tack any more JS on to the app.

@zyphlar
Copy link

zyphlar commented Aug 16, 2018 •
edited
Loading

In-work. Currently not taking JS into account.

zyphlar added a commit to zyphlar/securedrop that referenced this issue Aug 16, 2018
@zyphlar
Attempts to fix freedomofpress#2067 Pagination
d7b92a2 
- Increases the number of sources in dev data for easier pagination testing
- Paginates the list of sources in journalist interface
- Fixes the SD logo width for less redrawing during pageload
- Handles paginated sorting of starred items
- Keeps current pagination upon starring
zyphlar added a commit to zyphlar/securedrop that referenced this issue Aug 16, 2018
@zyphlar
Attempts to fix freedomofpress#2067 Pagination
dc19eef 
- Increases the number of sources in dev data for easier pagination testing
- Paginates the list of sources in journalist interface
- Fixes the SD logo width for less redrawing during pageload
- Handles paginated sorting of starred items
- Keeps current pagination upon starring
zyphlar added a commit to zyphlar/securedrop that referenced this issue Aug 16, 2018
@zyphlar
Attempts to fix freedomofpress#2067 Pagination
97d587b 
- Increases the number of sources in dev data for easier pagination testing
- Paginates the list of sources in journalist interface
- Fixes the SD logo width for less redrawing during pageload
- Handles paginated sorting of starred items
- Keeps current pagination upon starring
zyphlar added a commit to zyphlar/securedrop that referenced this issue Aug 17, 2018
@zyphlar
Attempts to fix freedomofpress#2067 Pagination
735c71e 
- Increases the number of sources in dev data for easier pagination testing
- Paginates the list of sources in journalist interface
- Fixes the SD logo width for less redrawing during pageload
- Handles paginated sorting of starred items
- Keeps current pagination upon starring
@zyphlar zyphlar mentioned this issue Aug 17, 2018
Closed
2 tasks
@eloquence eloquence mentioned this issue Dec 10, 2019
Open
rmol pushed a commit that referenced this issue Jun 8, 2020
@zyphlar @rmol
Attempts to fix #2067 Pagination
41b2553 
- Increases the number of sources in dev data for easier pagination testing
- Paginates the list of sources in journalist interface
- Fixes the SD logo width for less redrawing during pageload
- Handles paginated sorting of starred items
- Keeps current pagination upon starring
@eloquence
Copy link
Member

Closing per rationale here (API pagination - #5073 - is of course still very much on the table).

@zenmonkeykstop
Copy link
Contributor

It's worth looking at pagination or similar solutions to address potential timeouts on instances with a large (5k+) number of sources (though obviously the advice to journalists to delete old or unwanted conversations is still sound, the app server should not be seen as a long-term data store). Reopening for now.

@nabla-c0d3 nabla-c0d3 mentioned this issue Mar 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Attempts to fix #2067 Pagination zyphlar/securedrop
5 participants
@zyphlar @eloquence @zenmonkeykstop @heartsucker @redshiftzero