Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization name gets escaped twice #6357

Closed
eaon opened this issue Mar 23, 2022 · 1 comment · Fixed by #6550
Closed

Organization name gets escaped twice #6357

eaon opened this issue Mar 23, 2022 · 1 comment · Fixed by #6550
Labels

Comments

@eaon
Copy link
Contributor

eaon commented Mar 23, 2022

Description

When configuring an instance's name as (for example) "Hello & World", the & shows up as & wherever the organization name is used, because it is escaped when it is being set and again when it is being displayed.

Comments

As far as I can tell, the organization name is the only user provided input that is escaped before it is set - oversight or intentional?

@zenmonkeykstop
Copy link
Contributor

Probably more overzealousness!

@eloquence eloquence added the bug label Mar 25, 2022
eaon added a commit that referenced this issue Sep 19, 2022
If the entry is escaped, we'd need to mark every use of it in the
templates as `| safe` which is more dubious than not escaping the
database entry in the first place.

Fixes #6357
@eaon eaon mentioned this issue Sep 19, 2022
5 tasks
eaon added a commit that referenced this issue Sep 19, 2022
If the entry is escaped, we'd need to mark every use of it in the
templates as `| safe` which is more dubious than not escaping the
database entry in the first place.

Fixes #6357
eaon added a commit that referenced this issue Sep 19, 2022
If the entry is escaped, we'd need to mark every use of it in the
templates as `| safe` which is more dubious than not escaping the
database entry in the first place.

Fixes #6357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants