Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instruct users not to use XML templates for firewall config #2283

Merged
merged 3 commits into from
Sep 11, 2017
Merged

Instruct users not to use XML templates for firewall config #2283

merged 3 commits into from
Sep 11, 2017

Conversation

redshiftzero
Copy link
Contributor

Status

Ready for review

Description of Changes

Changes proposed in this pull request:

Testing

Review the small edits to the templates.

Review the docs.

Deployment

None, docs only.

Checklist

If you made changes to documentation:

  • Doc linting passed locally

@redshiftzero redshiftzero mentioned this pull request Sep 11, 2017
Closed
conorsch
conorsch approved these changes Sep 11, 2017
View reviewed changes
Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

We can revert de527dd when #2282 is addressed.

Nicely done. 👌

@redshiftzero
Copy link
Contributor Author

Thanks for the rapid review @conorsch!

@redshiftzero redshiftzero merged commit cb1d048 into release/0.4.3 Sep 11, 2017
@redshiftzero redshiftzero deleted the docs-dont-use-templates branch September 15, 2017 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conorsch conorsch conorsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@redshiftzero @conorsch