add confirmation flash when submission preferences are saved

[petevdp]

Status

Ready for review

Description of Changes

Fixes #5009.

Changes proposed in this pull request:

Add a flashed message when a user succesfully submits a change with the submission preferences form. The current implementation doesn't differentiate between submissions which actually change anything, but that should be easy enough if it would be desirable.

Testing

manual

• navigate to /admin/config
• choose a submission preference by checking/unchecking box
• hit 'update submission preferences'

A flashed message should show up, indicating that the setting has been successfully saved.

automated

I'm unsure if this feature needs automated testing. I'll be happy to add some if required!

Checklist

If you made changes to the server application code:

• [x ] Linting (make lint) and tests (make test) pass in the development container

If you made non-trivial code changes:

• I have written a test plan and validated it for this PR

Unsure if I need to do this, as mentioned above.

[eloquence]

Hi @petevdp, thanks for working on this! From my end, except for the two nits noted above, this looks good. Please give us a few days and a maintainer should be able to have a closer look.

From a UX perspective, it's a bit problematic that the confirmation only is noticeable when you scroll all the way to the bottom of the page:

That said, this in-line placement is consistent with how we handle logo updates on the same page. We may want to revisit that separately but I'd personally be OK with doing this in follow-up. CC @ninavizz for UX visibility.

[petevdp]

@eloquence Yeah it seems like we might want to add a more generalized system for the sort of confirmation/notification system that would be good for situations like this. Maybe something JS based, or a redirect to another page with the desired message.

That sounds like it might justify creating a separate issue, but I'd still like to work on that if i can.

[redshiftzero]

looks good! a few comments inline

[redshiftzero]

let's update or remove this comment (these are the flashed messages for the submission file preferences)

[eloquence]

Hi @petevdp, just touching base - do you have time to poke further at this? If not we can finish it up. Just let us know :)

[petevdp]

@eloquence Yeah I do, sorry for the lack of communication. I'm planning on working on it tomorrow!

[eloquence]

Awesome, thanks for the update! :)

[zenmonkeykstop]

Thanks for the update @petevdp - pushed little a commit to fix linter errors, will review once CI is passing.

[zenmonkeykstop]

Tested according to plan, working correctly. Automated tests also passing, so LGTM

[petevdp]

Awesome! Thanks for everyone's help, and sorry for the delay.
@zenmonkeykstop Apologies for the linting errors, definitely for got to run the linter 😅

[DrGFreeman]

Hi @petevdp, kudos for your contribution (got an email notification as I had commented on the issue).

As a new contributor to the project, I found this pre-commit hook quite useful to avoid forgetting the linting checks.

[petevdp]

@DrGFreeman Okay I'll install that, thanks!