Add LGTM configuration file #5076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add basic LGTM configuration file with exclsion of the following query: - py/import-and-import-from
Remove individual suppression of py/import-and-import-from LGTM queries as they are now excluded by default by the LGTM configuration file.
DrGFreeman
requested review from
heartsucker,
kushaldas and
redshiftzero
as code owners
zenmonkeykstop
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #5020 .
Changes proposed in this pull request:
Add a configuration file for LGTM tests with default exclusion of the
py/import-and-import-fromquery.Remove individual suppressions of the
py/import-and-import-fromquery in different files since it is now default in the configuration file.Testing
Verify that the LGTM analysis does not report any alerts against this PR.
Deployment
Any special considerations for deployment?
N/A
Checklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development containerIf you made changes to
securedrop-admin:make -C admin test) pass in the admin development containerIf you made changes to the system configuration:
If you made non-trivial code changes:
If you made changes to documentation:
make docs-lint) passed locallyIf you added or updated a code dependency:
Choose one of the following: