String fixes based on translator feedback #5391
Conversation
This is the terminology used in Tor browser See https://weblate.securedrop.org/translate/securedrop/securedrop/en/?checksum=8a1dbec76ada33ea#comments
| @@ -14,10 +14,10 @@ <h1>{{ gettext("Why download the team's public key?") }}</h1> | |||
| <li>{{ gettext('Encrypt your submission.') }} | |||
| <ol> | |||
| <li>{{ gettext('You will need to be able to identify the key (this is called the "user ID" or UID). Since the public key\'s filename is the key\'s fingerprint (with .asc at the end), you can just copy and paste that. (don\'t include the <code>.asc</code>!)')|safe }}</li> | |||
| <li>{{ gettext('On all systems, open the Terminal and use this gpg command: <code>gpg --recipient <user ID> --encrypt roswell_photos.pdf</code>')|safe }}</li> | |||
| <li>{{ gettext('On all systems, open the terminal and use this gpg command, replacing <code><user ID></code> and <code><filename></code> with their values:<br><code>gpg --recipient <user ID> --encrypt <filename></code>')|safe }}</li> | |||
There was a problem hiding this comment.
Eliminating the Roswell references is good, but I wonder if we want to avoid greater-than and less-than symbols in example commands, to avoid shell redirection problems if they're blindly copied and pasted. It was like this before, but we could take the opportunity to quote the example user ID and filename instead.
There was a problem hiding this comment.
This is scope creeping a little bit, but what do you think about the approach in f836393 of just pulling in the fingerprint so we don't have to use roundabout ways to describe it?
There was a problem hiding this comment.
That's better. I added the actual filename to the import command too, and tweaked the formatting of the commands.
There was a problem hiding this comment.
A bit of whitespace does wonders sometimes. Thanks @rmol, that looks good to me. I'll close this draft, squash, and open a new PR from a new branch name, since that change goes a bit beyond minor fixes at this point.
eloquence
force-pushed
the
minor-string-fixes
branch
from
e533236
to
f836393
Compare
Status
Ready for initial comments.
Will squash prior to promoting from draft.
Note: This PR is targeting 1.6.0, not 1.5.0.