String tweaks in response to feedback; add fingerprint to template #5399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add '.' to some messages [1] [2] [3] - Simplify and shorten validation warnings [4] - Tweak error message for bad form data case [5] - Avoid idiosyncratic ampersand usage per [6] - Pull closing tag into source string [7] - Change "Security Setting" to "Security Level", which is what Tor Browser now uses [8] - Desktop versions->desktop version [9] - Add submission key fingerprint to the "Why Journalist Key" template, to avoid convoluted instructions there; remove reference to UFO incident (This change was done in collaboration with @rmol) [1] https://weblate.securedrop.org/translate/securedrop/securedrop/en/?checksum=8e012ca12dd735dc#comments [2] https://weblate.securedrop.org/translate/securedrop/securedrop/en/?checksum=e2291f9285fe59af#comments [3] https://weblate.securedrop.org/translate/securedrop/securedrop/en/?checksum=782cc89459efa038#comments [4] https://weblate.securedrop.org/translate/securedrop/securedrop/en/?checksum=4422f6d628edc7de#comments [5] https://weblate.securedrop.org/translate/securedrop/securedrop/en/?checksum=511d2e2028f7fe91#comments [6] https://weblate.securedrop.org/translate/securedrop/securedrop/en/?checksum=aa334ee40ac41bf#comments [7] https://weblate.securedrop.org/translate/securedrop/securedrop/en/?checksum=486d7cd4ec4458de#comments [8] https://weblate.securedrop.org/translate/securedrop/securedrop/en/?checksum=8a1dbec76ada33ea#comments [9] https://weblate.securedrop.org/translate/securedrop/securedrop/en/?checksum=2f7252b4a244f071#comments
eloquence
requested review from
emkll,
kushaldas,
redshiftzero and
zenmonkeykstop
as code owners
|
(@rmol reviewed a prior version of this PR, and contributed to it, see here for history: #5391 (review)) |
zenmonkeykstop
approved these changes
Jul 30, 2020
gonzalo-bulnes
added a commit
to gonzalo-bulnes/securedrop
that referenced
this pull request
Aug 13, 2020
The corresponding code was fixed in freedomofpress#5399
gonzalo-bulnes
added a commit
to gonzalo-bulnes/securedrop
that referenced
this pull request
Aug 13, 2020
The corresponding code was fixed in freedomofpress#5399
gonzalo-bulnes
added a commit
to gonzalo-bulnes/securedrop
that referenced
this pull request
Aug 14, 2020
The corresponding code was fixed in freedomofpress#5399
gonzalo-bulnes
added a commit
to gonzalo-bulnes/securedrop
that referenced
this pull request
Aug 15, 2020
The corresponding code was fixed in freedomofpress#5399
gonzalo-bulnes
added a commit
to gonzalo-bulnes/securedrop
that referenced
this pull request
Aug 15, 2020
The corresponding code was fixed in freedomofpress#5399
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review. NB: This change is targeting SecureDrop 1.6.0, and does not need to be backported to 1.5.0.
Description
Misc. changes based on translator feedback, plus a change to the way that the submission key fingerprint is presented in the Source Interface:
(This change was done in collaboration with @rmol and only possible thanks to the feedback provided by many translators.)
[1] https://weblate.securedrop.org/translate/securedrop/securedrop/en/?checksum=8e012ca12dd735dc#comments
[2] https://weblate.securedrop.org/translate/securedrop/securedrop/en/?checksum=e2291f9285fe59af#comments
[3] https://weblate.securedrop.org/translate/securedrop/securedrop/en/?checksum=782cc89459efa038#comments
[4] https://weblate.securedrop.org/translate/securedrop/securedrop/en/?checksum=4422f6d628edc7de#comments
[5] https://weblate.securedrop.org/translate/securedrop/securedrop/en/?checksum=511d2e2028f7fe91#comments
[6] https://weblate.securedrop.org/translate/securedrop/securedrop/en/?checksum=aa334ee40ac41bf#comments
[7] https://weblate.securedrop.org/translate/securedrop/securedrop/en/?checksum=486d7cd4ec4458de#comments
[8] https://weblate.securedrop.org/translate/securedrop/securedrop/en/?checksum=8a1dbec76ada33ea#comments
[9] https://weblate.securedrop.org/translate/securedrop/securedrop/en/?checksum=2f7252b4a244f071#comments
Test plan
For the fingerprint changes:
http://localhost:8080/why-journalist-keyand that the instructions make sense.Checklist
docs-lintpassesmake testpasses (waiting for CI)