Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated route #5440

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Remove duplicated route #5440

merged 1 commit into from
Aug 11, 2020

Conversation

eloquence
Copy link
Member

@eloquence eloquence commented Aug 7, 2020

Status

Ready for review

Description of Changes

Removes an unintentionally duplicated route. No test implications as far as I can tell, as the method is not tested via a unit test.

Resolves #5434

Test plan

  1. Build a development environment from this branch
  2. Log in as an admin user
  3. Attempt to change an existing user's password (not your own) using the web-based "Admin" interface. Note down the new password.
  • Observe that the password change is completed successfully.
  • Observe that you can log in as the user whose password you changed.

Checklist

  • Linting (make lint) and tests (make test) pass in the development container

Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Build a development environment from this branch
  • Log in as an admin user
  • Attempt to change an existing user's password (not your own) using the web-based "Admin" interface. Note down the new password.
  • Observe that the password change is completed successfully.
  • Observe that you can log in as the user whose password you changed.

Worked as expected. Approved.

@kushaldas kushaldas merged commit 63f231c into develop Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new-password route is defined twice
2 participants