Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify journalist 2fa TOTP secret style #5574

Merged

Conversation

DrGFreeman
Copy link
Contributor

@DrGFreeman DrGFreeman commented Oct 11, 2020

Status

Ready for review.

Description of Changes

Fixes #1598

Changes proposed in this pull request:

Change styling of journalist 2FA TOTP secret text:

  • Change background color to light grey
  • Remove border
  • Increase lateral and vertical padding
  • Use monospace font
  • Increase font size
  • Use bold font weight

Testing

How should the reviewer test this PR?
Write out any special testing steps here.

  1. Run make dev.
  2. In journalist interface, create a new user.
  3. On the /admin/2fa page, check the style of the TOTP secret text. The expected style is shown in the screenshot below.

Deployment

Any special considerations for deployment? Consider both:

  1. Upgrading existing production instances.
  2. New installs.

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make test) pass in the development container

If you made changes to securedrop-admin:

  • Linting and tests (make -C admin test) pass in the admin development container

If you made changes to the system configuration:

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

If you made changes to documentation:

  • Doc linting (make docs-lint) passed locally

If you added or updated a code dependency:

Choose one of the following:

  • I have performed a diff review and pasted the contents to the packaging wiki
  • I would like someone else to do the diff review

- Change background color to light grey
- Remove border
- Increase lateral and vertical padding
- Use monospace font
- Increase font size
- Use bold font weight
@DrGFreeman
Copy link
Contributor Author

Expected style:

image

@DrGFreeman DrGFreeman marked this pull request as ready for review October 11, 2020 11:55
@emkll emkll added this to Ready for Review in SecureDrop Team Board Oct 13, 2020
Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI looks good and same as in the screenshot.

sd_review_css

@kushaldas kushaldas merged commit e21403c into freedomofpress:develop Oct 14, 2020
SecureDrop Team Board automation moved this from Ready for Review to Done Oct 14, 2020
@eloquence eloquence added this to the 1.7.0 milestone Jan 5, 2021
@conorsch conorsch mentioned this pull request Jan 15, 2021
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

/admin/2fa view has ugly yellow syntax code block style for new TOTP secret
3 participants