-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix session expiry message #5582
Fix session expiry message #5582
Conversation
Hi @sheonhan, thanks for working on this! :) It looks like you accidentally included a few unrelated comits in this PR: https://github.com/freedomofpress/securedrop/pull/5582/commits Just let us know if you need help resolving. |
Hi @eloquence, thanks for your quick reply. Looks like I made a mistake while trying to rebase it 😅 . Will clean up and push it again with clean commits! |
136b503
to
78654c0
Compare
I addressed this issue by creating two new properties ( But I wasn't sure if persisting two properties across sessions—even though they are simple boolean values—is discouraged from a security standpoint. I'd love feedbacks on whether this is an acceptable approach. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had one suggestion for the property naming. Otherwise this looks good.
Status
Ready for Review
Description of Changes
Fixes #5197
Testing
SESSION_EXPIRATION_MINUTES
.Checklist
If you made changes to the server application code:
make lint
) and tests (make test
) pass in the development containerIf you made non-trivial code changes: