Update CI docker images with CircleCI python images #5720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docker container provided by GCPs cloud-builders now recommends in its README the use of other docker containers, and is still running on Xenial. Since they are essentially swappable in place, here we use the containers that are maintained by the CI provider [2] [1] https://github.com/GoogleCloudPlatform/cloud-builders [2] https://circleci.com/developer/images/image/cimg/python
Codecov Report
@@ Coverage Diff @@
## develop #5720 +/- ##
========================================
Coverage 85.58% 85.58%
========================================
Files 52 52
Lines 3773 3773
Branches 471 471
========================================
Hits 3229 3229
Misses 439 439
Partials 105 105 Continue to review full report at Codecov.
|
zenmonkeykstop
approved these changes
Jan 19, 2021
This was referenced Jan 19, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #5719
The container image provided by GCPs cloud-builders now recommends in its README the use of other docker containers, and is still running on Xenial. Since they are essentially swappable in place, here we use the containers that are maintained by the CI provider [2]
[1] https://github.com/GoogleCloudPlatform/cloud-builders
[2] https://circleci.com/developer/images/image/cimg/python
Testing
Deployment
Test/CI only