Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump 2FA secret bit length from 80 to 160 bits as recommended by RFC4226 #5958

Merged
merged 11 commits into from
Sep 1, 2021
Merged

Bump 2FA secret bit length from 80 to 160 bits as recommended by RFC4226 #5958

merged 11 commits into from
Sep 1, 2021

Commits on Sep 1, 2021

  1. Bump 2FA secret bit length from 80 bits to 160 bits as recommended by… 

    … RFC4226
    @evilaliv3 @zenmonkeykstop
    evilaliv3 authored and zenmonkeykstop committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    d806f76 View commit details
    Browse the repository at this point in the history

  2. Adds type comparison to alembic migrations and adds migration for jou… 

    …rnalists.otp_secret length change
    @zenmonkeykstop
    zenmonkeykstop committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    4e86002 View commit details
    Browse the repository at this point in the history

  3. Added migration test for otp_secret length change.

    @zenmonkeykstop
    zenmonkeykstop committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    5d33f26 View commit details
    Browse the repository at this point in the history

  4. updated pyotp to 2.6.0, used its secret generator with 32-char default

    @zenmonkeykstop
    zenmonkeykstop committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    752e8eb View commit details
    Browse the repository at this point in the history

  5. Adds more type checking for latest mypy 

    We need to assert the type of the variable for any Optional
type.
    @kushaldas @zenmonkeykstop
    kushaldas authored and zenmonkeykstop committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    e0cbfa4 View commit details
    Browse the repository at this point in the history

  6. Fixes #6070 we can again use update command

    @kushaldas @zenmonkeykstop
    kushaldas authored and zenmonkeykstop committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    62d5738 View commit details
    Browse the repository at this point in the history

  7. Adds alembic head merge

    @kushaldas @zenmonkeykstop
    kushaldas authored and zenmonkeykstop committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    6c93f91 View commit details
    Browse the repository at this point in the history

  8. Adds validation for variable before assert statement

    @kushaldas @zenmonkeykstop
    kushaldas authored and zenmonkeykstop committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    bca62ae View commit details
    Browse the repository at this point in the history

  9. Puts assert statement in right condition block

    @kushaldas @zenmonkeykstop
    kushaldas authored and zenmonkeykstop committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    6ef77a8 View commit details
    Browse the repository at this point in the history

  10. placate flake8

    @zenmonkeykstop
    zenmonkeykstop committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    f5370fb View commit details
    Browse the repository at this point in the history

  11. Replace alembic merge with version order tweak. 

    A merge version is recommended for situations where alembic history
has multiple heads, but in this case that was breaking the upgrade/downgrade
tests. Since the db changes in question are not yet in prod, it's ok
to reorder the history instead - so the otp_secret change has been moved from
its own alembic branch to the head of the existing one.
    @zenmonkeykstop
    zenmonkeykstop committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    c779e1c View commit details
    Browse the repository at this point in the history