Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mypy configuration for Python 3.8 #5977

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Update mypy configuration for Python 3.8 #5977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ shellcheckclean: ## Clean up temporary container associated with shellcheck tar
typelint: ## Run mypy type linting.
@echo "███ Running mypy type checking..."
@mypy ./securedrop ./admin
@mypy --disallow-incomplete-defs --disallow-untyped-defs ./securedrop/rm.py
@echo

.PHONY: yamllint
Expand Down
3 changes: 2 additions & 1 deletion mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
ignore_missing_imports = True
no_implicit_optional = True
disallow_untyped_defs = True
python_version = 3.5
disallow_incomplete_defs = True
python_version = 3.8

[mypy-tests.*]
disallow_untyped_defs = False
2 changes: 1 addition & 1 deletion securedrop/tests/utils/db_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ def new_codename(client, session):
return codename


def bulk_setup_for_seen_only(journo) -> List[Dict]:
def bulk_setup_for_seen_only(journo: Journalist) -> List[Dict]:
"""
Create some sources with some seen submissions that are not marked as 'downloaded' in the
database and some seen replies from journo.
Expand Down