Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Debian 11 for dev env #6106

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Support Debian 11 for dev env #6106

merged 1 commit into from
Sep 30, 2021

Conversation

conorsch
Copy link
Contributor

@conorsch conorsch commented Sep 23, 2021

Status

Ready for review

Description of Changes

Towards freedomofpress/securedrop-dev-docs#9 , adding support for Debian 11

While testing the dev env on Debian 11 Bullseye, was not able to install
the development requirements due to an error on pyenchant. Bumping the
req to a recent version resolved for me.

Marking as a draft because I haven't tested on Buster, and there may be more changes that should be appended here (as well as changes to the docs).

Testing

You must use a Debian 11 machine to test! Following the docs in https://docs.securedrop.org/en/latest/development/setup_development.html#install-python-requirements , make sure you see no errors (or report ones you do encounter!).

Deployment

So far, dev-env only.

Checklist

I haven't performed a diff review, but this is explicitly a dev req.

Towards https://github.com/freedomofpress/securedrop-docs/issues/255

While testing the dev env on Debian 11 Bullseye, was not able to install
the development requirements due to an error on pyenchant. Bumping the
req to a recent version resolved for me.
@conorsch
Copy link
Contributor Author

@tesitura Please take this for a spin and see if it unblocks you!

@conorsch conorsch added this to In Development in SecureDrop Team Board Sep 23, 2021
@conorsch conorsch removed this from In Development in SecureDrop Team Board Sep 23, 2021
@kushaldas
Copy link
Contributor

Tested on both Debian 10 and a fresh Debian 11 system. Works for me. @conorsch +1 from me :)

@eloquence eloquence added this to Next sprint candidates in SecureDrop Team Board Sep 29, 2021
@eloquence eloquence moved this from Next sprint candidates to To Do (Kanban Mode) in SecureDrop Team Board Sep 29, 2021
@conorsch
Copy link
Contributor Author

Marking ready for review. @kushaldas tried it and liked it, and @tesitura was also able to spin up the VM environments on Bullseye, with this change in the mix. There are still some superficial docs updates required, e.g. mentioning testing Debian 11, but this seems to be all that's necessary diff-wise so far.

@conorsch conorsch marked this pull request as ready for review September 29, 2021 18:44
@conorsch conorsch requested a review from a team as a code owner September 29, 2021 18:44
Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as expected on both Debian 10 and Debian 11. Approved.

@kushaldas kushaldas merged commit a12e38d into develop Sep 30, 2021
SecureDrop Team Board automation moved this from SecureDrop Sprint #76 - 9/29 - 10/13 to Done Sep 30, 2021
@kushaldas kushaldas deleted the bullseye-dev-env branch September 30, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants