Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l10n: update strings to be translated for v2.4.0 #6436

Merged
merged 2 commits into from
May 6, 2022

Conversation

cfm
Copy link
Member

@cfm cfm commented May 6, 2022

Status

Ready for review

Description of Changes

Updates the messages.pot template and all supported languages' message.po catalogs with the strings to be translated for v2.4.0.

Per #6156, tentatively includes pt_PT as a supported language. See "Deployment" below for related considerations.

Testing

  • Visually sanity-check:
    • the messages.pot template; and
    • the messages.po catalog for the language of your choice.

Deployment

  • 78c23b0 should be reverted before merging translations into develop if pt_PT doesn't reach adequate coverage to be included in this release.

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make test) pass in the development container

cfm and others added 2 commits May 5, 2022 21:32
Per #6156, include pt_PT as a supported language during the v2.4.0
translation period.  Revert this commit before merging translations into
"develop" if this translation doesn't reach adequate coverage to be
included in this release.
@cfm cfm added the i18n Anything related to translation or internationalization of SecureDrop label May 6, 2022
@cfm cfm added this to the 2.4.0 milestone May 6, 2022
@cfm cfm requested a review from a team as a code owner May 6, 2022 04:38
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2022

Codecov Report

Merging #6436 (4e18e87) into develop (4fd2727) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #6436   +/-   ##
========================================
  Coverage    83.83%   83.83%           
========================================
  Files           62       62           
  Lines         4331     4331           
  Branches       525      525           
========================================
  Hits          3631     3631           
  Misses         575      575           
  Partials       125      125           
Impacted Files Coverage Δ
securedrop/i18n_tool.py 84.45% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@cfm cfm added this to Ready for Review in SecureDrop Team Board May 6, 2022
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenmonkeykstop zenmonkeykstop merged commit f384d7c into develop May 6, 2022
SecureDrop Team Board automation moved this from Ready for Review to Done May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything related to translation or internationalization of SecureDrop
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants