Bring new fixtures to Journalist interface layout tests #6504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabla-c0d3
force-pushed
the
refactor-layout-tests-journalist
branch
3 times, most recently
from
5b23420
to
493d4da
Compare
nabla-c0d3
force-pushed
the
refactor-layout-tests-journalist
branch
from
493d4da
to
c1b4fc3
Compare
nabla-c0d3
commented
Aug 10, 2022
|
|
||
|
|
||
| @pytest.mark.parametrize("locale", list_locales()) |
There was a problem hiding this comment.
Below I merged some of the "screenshot-taking" tests, so that the test suite would run faster.
|
|
||
| def test_index_no_documents_admin(self): | ||
| self._admin_logs_in() | ||
| self._screenshot("journalist-admin_index_no_documents.png") |
There was a problem hiding this comment.
This screenshot is still referenced in the documentation.
| self._source_submits_a_message() | ||
| self._source_logs_out() | ||
| self._journalist_logs_in() | ||
| self._screenshot("journalist-index_javascript.png") |
There was a problem hiding this comment.
This screenshot is still referenced in the documentation
|
|
||
| def test_index_entered_text(self): | ||
| self._input_text_in_login_form("jane_doe", "my password is long", "117264") | ||
| self._screenshot("journalist-index_with_text.png") |
There was a problem hiding this comment.
This screenshot is still referenced in the docs.
zenmonkeykstop
requested changes
Aug 15, 2022
|
@zenmonkeykstop Good catch - I didn't realize that this was how the screenshots were used. I've re-added the missing ones, and left the changes as a separate commit so that it's easier to review. Thanks! |
zenmonkeykstop
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready
Description of Changes
This PR continue the work from #6503, by bringing the new test code and fixtures to some of the layout tests for the journalist app.
More specifically, this PR: