Simplify i18n tests and remove sh.sed usage #6562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nabla-c0d3
force-pushed
the
simplify-i18n-tests-and-remove-sed-usage
branch
from
175475e
to
4c05629
Compare
|
This pull request introduces 2 alerts when merging 4c05629 into ce7077d - view on LGTM.com new alerts:
|
nabla-c0d3
force-pushed
the
simplify-i18n-tests-and-remove-sed-usage
branch
from
4c05629
to
b0adc04
Compare
|
This pull request introduces 2 alerts when merging b0adc04 into ce7077d - view on LGTM.com new alerts:
|
This was referenced Sep 25, 2022
legoktm
reviewed
Sep 26, 2022
nabla-c0d3
force-pushed
the
simplify-i18n-tests-and-remove-sed-usage
branch
from
b0adc04
to
b420f79
Compare
|
This pull request introduces 2 alerts when merging b420f79 into cc551cf - view on LGTM.com new alerts:
|
nabla-c0d3
force-pushed
the
simplify-i18n-tests-and-remove-sed-usage
branch
from
b420f79
to
ed2f848
Compare
|
This pull request introduces 2 alerts when merging ed2f848 into cc551cf - view on LGTM.com new alerts:
|
nabla-c0d3
force-pushed
the
simplify-i18n-tests-and-remove-sed-usage
branch
from
ed2f848
to
eb9ef64
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready
Description of Changes
journalist_appandconfigfixtures, which are not actually needed by the tests.sh.sed(Removeshdependency #6547).This PR should be reviewed and merged after #6551.