Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add splash screens for Android and iOS #167

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Add splash screens for Android and iOS #167

merged 1 commit into from
Oct 3, 2018

Conversation

rafmjr
Copy link
Contributor

@rafmjr rafmjr commented Oct 2, 2018

Added support for splash screens on mobile devices (Android and iOS). The standard manifest.json file was used to setup a basic screen displaying a white version of the logo on top of a green background, whereas the splash screen for iOS was a little more involved due to the lack fully support of PWA.

Prompting the user for installation should be supported by adding a Service Worker.

This should help to solve the issue [Add a splash screen #157](Add a splash screen )

@ubaldop
Copy link
Collaborator

ubaldop commented Oct 2, 2018

hi @rafmjr, impressive, thank you for your contribution!
@mcicolella do you think shall be useful to introduce a Service Worker to make fd-vue-webapp fully PWA compliant?
I am not quite familiar about PWA proper setup.

@mcicolella are you able to test this PR on iOS?

@mcicolella
Copy link
Collaborator

@p3trur0 I don't have an iOS phone. Currently I'm testing mobile layout on Chrome with UA Spoofer.

@ubaldop
Copy link
Collaborator

ubaldop commented Oct 3, 2018

@rafmjr would you like to help us in making this application a PWA? I am going to open an issue in minutes.
Moreover, are you familiar with any iOS simulator to test your Splash Screen addition?

@rafmjr
Copy link
Contributor Author

rafmjr commented Oct 3, 2018

@p3trur0 it would be my pleasure to help you with that issue. Now, regarding on how to test these splash screens in iOS, if you don't have an iPhone, you would need to install xcode and start a simulator from there.

@ubaldop ubaldop merged commit 948f1cf into freedomotic:master Oct 3, 2018
@ubaldop
Copy link
Collaborator

ubaldop commented Oct 3, 2018

@rafmjr glad to hear that! So, please, feel free to take #177.
Also, thank you for pointing out the xcode option for testing iOS splash screen.

So far I do not have a Macbook machine, however I merge this PR because personally it looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants