Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code gardening and Javadoc update of Reaction class #409

Open
mcicolella opened this issue Oct 29, 2017 · 0 comments
Open

Code gardening and Javadoc update of Reaction class #409

mcicolella opened this issue Oct 29, 2017 · 0 comments

Comments

@mcicolella
Copy link
Collaborator

Remove all issues reported by Sonarcloud and update Javadoc.

PLEASE BE CAREFUL BEFORE SENDING A PR

  1. Double check every issue with great attention. Sonarcloud sometimes reports 'false' issues (e.g. unused variables but they are really used). In case of doubt ask our team
  2. For Javadoc please follow the official style guide conventions http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html
  3. Review texts and fix typos and/or grammatical errors
  4. Compile the code
  5. Run the code to be sure there aren't runtime exceptions
  6. If you want to propose a better implementation please add a comment describing your proposal of refactoring
  7. Submit a PR with a single commit

NOTE: Don't remove "deprecated" methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant