Skip to content

Commit

Permalink
ipatests: Specify shell implementation
Browse files Browse the repository at this point in the history
The shell command line options and parameters used there are bash-
specific. This results in an error on attempting of running
'ipa-run-tests' on systems where '/bin/sh' is pointing to another
shell, for example, dash on Ubuntu.

Fixes: https://pagure.io/freeipa/issue/8101
Signed-off-by: Stanislav Levin <slev@altlinux.org>
Reviewed-By: Sergey Orlov <sorlov@redhat.com>
  • Loading branch information
stanislavlevin authored and sorlov-rh committed Apr 21, 2020
1 parent 6d8d167 commit 9743957
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ipatests/ipa-run-tests
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ if not has_option("junit_family"):
pyt_args = [sys.executable, "-c",
"import sys,pytest;sys.exit(pytest.main())"] + sys.argv[1:]
# shell is needed to perform globbing
sh_args = ["/bin/sh", "--norc", "--noprofile", "-c", "--"]
sh_args = ["/bin/bash", "--norc", "--noprofile", "-c", "--"]
pyt_args_esc = [
f"'{x}'" if not x or " " in x else x
for x in pyt_args
Expand Down

0 comments on commit 9743957

Please sign in to comment.