Test for ipahealthcheck.ipa.idns check when integrated DNS is setup

This testcase compares the output of ipahealtcheck.ipa.dns check
with the SRV records displayed by 'ipa dns-update-system-records --dry-run'
command executed on IPA server with integrated DNS setup.

https://bugzilla.redhat.com/show_bug.cgi?id=1695125

Signed-off-by: sumenon <sumenon@redhat.com>
Reviewed-By: Rob Crittenden <rcritten@redhat.com>
Reviewed-By: Mohammad Rizwan Yusuf <myusuf@redhat.com>

ipatests/test_integration/test_ipahealthcheck.py

@@ -21,7 +21,7 @@
 HEALTHCHECK_LOG_ROTATE_CONF = "/etc/logrotate.d/ipahealthcheck"
 HEALTHCHECK_LOG_DIR = "/var/log/ipa/healthcheck"
 HEALTHCHECK_OUTPUT_FILE = "/tmp/output.json"
-HEALTHCHECK_PKG = ['freeipa-healthcheck']
+HEALTHCHECK_PKG = ["*ipa-healthcheck"]
 TOMCAT_CFG = "/var/lib/pki/pki-tomcat/conf/ca/CS.cfg"
 
 
@@ -108,7 +108,6 @@
     "auditSigningCert cert-pki-kra",
 ]
 
-
 def run_healthcheck(host, source=None, check=None, output_type="json"):
     """
     Run ipa-healthcheck on the remote host and return the result
@@ -457,6 +456,55 @@ def test_ipa_healthcheck_log_rotate_file_exist_issue35(self):
         )
         assert msg not in cmd.stdout_text
 
+    def test_ipa_dns_systemrecords_check(self):
+        """
+        This test ensures that the ipahealthcheck.ipa.idns check
+        displays the correct result when master and replica is setup
+        with integrated DNS.
+        """
+        SRV_RECORDS = [
+            "_ldap._tcp." + self.replicas[0].domain.name + ".:" +
+            self.replicas[0].hostname + ".",
+            "_ldap._tcp." + self.master.domain.name + ".:" +
+            self.master.hostname + ".",
+            "_kerberos._tcp." + self.replicas[0].domain.name + ".:" +
+            self.replicas[0].hostname + ".",
+            "_kerberos._tcp." + self.master.domain.name + ".:" +
+            self.master.hostname + ".",
+            "_kerberos._udp." + self.replicas[0].domain.name + ".:" +
+            self.replicas[0].hostname + ".",
+            "_kerberos._udp." + self.master.domain.name + ".:" +
+            self.master.hostname + ".",
+            "_kerberos-master._tcp." + self.replicas[0].domain.name +
+            ".:" + self.replicas[0].hostname + ".",
+            "_kerberos-master._tcp." + self.master.domain.name + ".:" +
+            self.master.hostname + ".",
+            "_kerberos-master._udp." + self.replicas[0].domain.name +
+            ".:" + self.replicas[0].hostname + ".",
+            "_kerberos-master._udp." + self.master.domain.name + ".:" +
+            self.master.hostname + ".",
+            "_kpasswd._tcp." + self.replicas[0].domain.name + ".:" +
+            self.replicas[0].hostname + ".",
+            "_kpasswd._tcp." + self.master.domain.name + ".:" +
+            self.master.hostname + ".",
+            "_kpasswd._udp." + self.replicas[0].domain.name + ".:" +
+            self.replicas[0].hostname + ".",
+            "_kpasswd._udp." + self.master.domain.name + ".:" +
+            self.master.hostname + ".",
+            "\"" + self.master.domain.realm.upper() + "\"",
+            self.master.ip,
+            self.replicas[0].ip
+        ]
+        returncode, data = run_healthcheck(
+            self.master,
+            "ipahealthcheck.ipa.idns",
+            "IPADNSSystemRecordsCheck"
+        )
+        assert returncode == 0
+        for check in data:
+            assert check["result"] == "SUCCESS"
+            assert check["kw"]["key"] in SRV_RECORDS
+
     def test_ipa_healthcheck_remove(self):
         """
         This testcase checks the removal of of healthcheck tool