Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump pki min version and add commentary about sub-CA revocation on delete #108

Closed
wants to merge 2 commits into from
Closed

Bump pki min version and add commentary about sub-CA revocation on delete #108

wants to merge 2 commits into from

Conversation

frasertweedale
Copy link
Contributor

@frasertweedale frasertweedale commented Sep 23, 2016 •
edited by MartinBasti

@frasertweedale frasertweedale changed the title https://fedorahosted.org/freeipa/ticket/6256 Bump pki min version and add commentary about sub-CA revocation on delete Sep 23, 2016
@MartinBasti MartinBasti self-assigned this Sep 26, 2016
@MartinBasti
Copy link
Contributor

I don't think that bumping BuildRequires is needed

Also you are changing strings used for translations, so I'd use this change and rather add new things to doc string using http://www.freeipa.org/page/Coding_Best_Practices#Split_long_translatable_strings It will help translators in future

@frasertweedale
Copy link
Contributor Author

@mbasti-rh I think the BuildRequires bump is appropriate. If we say (in the doc) that
such and such will happen, we want to be sure that they are using the version of
Dogtag that actually implements it.

@MartinBasti
Copy link
Contributor

IMO for that there is 'Requires' statement. We don't need 10.3.5-6 during build time and IIRC Honza is working on 'Fix IPA dependencies' patch and he will even decrease BuildRequires for pki'

@frasertweedale
Copy link
Contributor Author

On Tue, Oct 04, 2016 at 11:41:39PM -0700, mbasti-rh wrote:

IMO for that there is 'Requires' statement. We don't need 10.3.5-6 during build time and IIRC Honza is working on 'Fix IPA dependencies' patch and he will even decrease BuildRequires for pki'

Ah right, yeah. Misunderstood earlier comment. I'll cut a new
patch that doesn't touch BuildRequires (neither bumping it, nor
removing).

Thanks,
Fraser

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#108 (comment)

@frasertweedale
spec: require Dogtag >= 10.3.5-6
b97b8c9 
Require Dogtag 10.3.5-6, which is the first release that implements
revocation of lightweight CA signing certificates upon deletion.

Part of: https://fedorahosted.org/freeipa/ticket/6256
@frasertweedale
Add commentary about CA deletion to plugin doc
42a2db9 
Add commentary to 'ca' plugin documentation to explain what happens
when a CA gets deleted - namely, that its signing cert gets revoked
and its private key deleted.

Also break the docstring up into smaller chunks to aid translation.

Fixes: https://fedorahosted.org/freeipa/ticket/6256
@MartinBasti MartinBasti added the ack Pull Request approved, can be merged label Oct 6, 2016
@MartinBasti
Copy link
Contributor

Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/6b3f4984296f3caff8f29490eae3ed1dca64b8c3
https://fedorahosted.org/freeipa/changeset/2b8163ab5dfcf28a9eba319ef685046ae9d8b5e8
ipa-4-4:
https://fedorahosted.org/freeipa/changeset/358e50b2e194d3ae3d0e8c22c774a24ab84d8be1
https://fedorahosted.org/freeipa/changeset/810c38efce6a3911b39e29b7aac010e467ef25a7

@MartinBasti MartinBasti added the pushed Pull Request has already been pushed label Oct 6, 2016
@MartinBasti MartinBasti closed this Oct 6, 2016
@frasertweedale frasertweedale deleted the fix/6256-ca-del-revoke-cert branch October 27, 2016 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MartinBasti MartinBasti

Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
2 participants
@frasertweedale @MartinBasti