Remove vestigal references to Firefox autoconfig xpi and caJarSigningCert profile #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin was removed some time ago. Part of: https://pagure.io/freeipa/issue/7226
We added MIME types for JAR and XPI files, which were needed for correct handling of the Firefox auto-configuration plugin. The plugin was removed some time ago, so remove the media type definitions. Part of: https://pagure.io/freeipa/issue/7226
The CertDB.issue_signing_cert method was used to issue the object signing cert for signing the Firefox auto-configuration extension (XPI). We removed the extension and certificate some time ago, and the method is now unused so remove it. Part of: https://pagure.io/freeipa/issue/7226
The caJarSigningCert profile was used for issuing the object signing certificate for signing the Firefox auto-configuration extension (XPI). We removed the extension and object signing certificate some time ago, so remove the profile and the related code that sets it up. Fixes: https://pagure.io/freeipa/issue/7226
|
These patches look good to me. Can you also reference this ticket somewhere, https://pagure.io/freeipa/issue/7135? This was the original "remove Firefox" ticket, these other bits just got left behind. I think I'd even be ok mentioning it in the ticket itself. |
|
@rcritten thanks; I added a reference to 7135 in 7226 and vice versa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pagure.io/freeipa/issue/7226