Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dnsrecord_show for structured record #1324

Closed
wants to merge 2 commits into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Nov 22, 2017

@tiran tiran added the py3 label Nov 22, 2017
@tiran tiran force-pushed the issue7275_dnsrecord_show branch 6 times, most recently from 4041a26 to 55da8ca Compare November 22, 2017 19:34
"RuntimeError: dictionary changed size during iteration" in
ipaserver/plugins/dns.py", line 3209, in postprocess_record

https://pagure.io/freeipa/issue/7275

Signed-off-by: Christian Heimes <cheimes@redhat.com>
In structured mode, dict size is modified by del record[attr].

https://pagure.io/freeipa/issue/7275

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@flo-renaud flo-renaud self-assigned this Nov 27, 2017
@flo-renaud
Copy link
Contributor

Hi @tiran
thank you for the patch and the corresponding test. Everything works as expected.

@flo-renaud flo-renaud added the ack Pull Request approved, can be merged label Nov 27, 2017
@tiran tiran added the pushed Pull Request has already been pushed label Nov 27, 2017
@tiran
Copy link
Member Author

tiran commented Nov 27, 2017

master:

  • 191605e Reproducer for bug in structured dnsrecord_show
  • f528a44 Fix dict iteration bug in dnsrecord_show

@tiran tiran closed this Nov 27, 2017
@tiran tiran deleted the issue7275_dnsrecord_show branch November 27, 2017 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
2 participants