Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][ipa-4-6] Fix pylint warnings inconsistent-return-statements #1411

Closed
wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Dec 18, 2017

This PR was opened manually because PR #1408 was pushed to master and backport to ipa-4-6 is required.

Add consistent return to all functions and methods that are covered by
tox -e pylint[23]. I haven't checked if return None is always a good
idea or if we should rather raise an error.

See: https://pagure.io/freeipa/issue/7326
Signed-off-by: Christian Heimes <cheimes@redhat.com>
Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
@tiran
Copy link
Member Author

tiran commented Dec 18, 2017

PR was ACKed automatically because this is backport of PR #1408. Wait for CI to finish before pushing. In case of questions or problems contact @tiran who is author of the original PR.

@tiran tiran added ack Pull Request approved, can be merged pushed Pull Request has already been pushed labels Dec 18, 2017
@tiran
Copy link
Member Author

tiran commented Dec 18, 2017

ipa-4-6:

  • 843a59a Fix pylint warnings inconsistent-return-statements

@tiran tiran closed this Dec 18, 2017
@tiran tiran deleted the backport_pr1408_ipa-4-6 branch March 29, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
1 participant