Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][ipa-4-6] Fix pylint error in ipapython/dn.py #1487

Closed
wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Jan 23, 2018

ipapython/dn.py:1324: [R1710(inconsistent-return-statements), DN.contains]
Either all return statements in a function should return an expression, or none of them should.)

Signed-off-by: Christian Heimes cheimes@redhat.com

Manual backport of PR #1486 to speed things up.

ipapython/dn.py:1324: [R1710(inconsistent-return-statements), DN.__contains__]
Either all return statements in a function should return an expression, or none of them should.)

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran tiran added prioritized Pull Request has higher priority for PR-CI trivial needs review Pull Request is waiting for a review labels Jan 23, 2018
@tiran tiran changed the title Fix pylint error in ipapython/dn.py [Backport][ipa-4-6] Fix pylint error in ipapython/dn.py Jan 23, 2018
@tiran
Copy link
Member Author

tiran commented Jan 23, 2018

PR was ACKed manually because this is backport of PR #1486. Wait for CI to finish before pushing. In case of questions or problems contact @tiran who is author of the original PR.

@tiran tiran added ack Pull Request approved, can be merged re-run Trigger a new run of PR-CI and removed needs review Pull Request is waiting for a review labels Jan 23, 2018
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Jan 23, 2018
@tiran tiran added the pushed Pull Request has already been pushed label Jan 23, 2018
@tiran
Copy link
Member Author

tiran commented Jan 23, 2018

ipa-4-6:

  • ec60db3 Fix pylint error in ipapython/dn.py

@tiran tiran closed this Jan 23, 2018
@tiran tiran deleted the backport_pr1486_ipa-4-6 branch March 29, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged prioritized Pull Request has higher priority for PR-CI pushed Pull Request has already been pushed trivial
Projects
None yet
2 participants