Replace wsgi package conflict with config file #1523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
force-pushed
the
issue7394-wsgi-conf
branch
from
1b785c5
to
faaeaf8
Compare
tiran
added
prioritized
Rezney
reviewed
Feb 6, 2018
ipaplatform/base/tasks.py
Outdated
| def configure_httpd_wsgi_conf(self): | ||
| """Configure WSGI for correct Python version""" | ||
| # only used on Fedora, NOP on other platforms | ||
|
|
There was a problem hiding this comment.
raise NotImplementedError() missing
There was a problem hiding this comment.
Nope, I did this on purpose. The function is not implemented on any platform except Fedora.
ipaplatform/redhat/tasks.py
Outdated
| if sys.version_info > (3, 0): | ||
| wsgi_module = constants.MOD_WSGI_PYTHON3 | ||
| else: | ||
| wsgi_module = constants.MOD_WSGI_PYTHON3 |
There was a problem hiding this comment.
should not it be constants.MOD_WSGI_PYTHON2 here?
Instead of a package conflict, freeIPA now uses an Apache config file to enforce the correct wsgi module. The workaround only applies to Fedora since it is the only platform that permits parallel installation of Python 2 and Python 3 mod_wsgi modules. RHEL 7 has only Python 2 and Debian doesn't permit installation of both variants. See: https://pagure.io/freeipa/issue/7161 Fixes: https://pagure.io/freeipa/issue/7394 Signed-off-by: Christian Heimes <cheimes@redhat.com>
tiran
force-pushed
the
issue7394-wsgi-conf
branch
from
faaeaf8
to
748ca34
Compare
rcritten
added
ack
|
master:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a package conflict, freeIPA now uses an Apache config file to
enforce the correct wsgi module. The workaround only applies to Fedora
since it is the only platform that permits parallel installation of
Python 2 and Python 3 mod_wsgi modules. RHEL 7 has only Python 2 and
Debian doesn't permit installation of both variants.
Fixes: https://pagure.io/freeipa/issue/7394
Signed-off-by: Christian Heimes cheimes@redhat.com