Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport][ipa-4-5] test_caless: adjust try/except to capture IOError #1682

Closed
wants to merge 1 commit into from
Closed

[Backport][ipa-4-5] test_caless: adjust try/except to capture IOError #1682

wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Mar 14, 2018 •
edited

This PR was opened automatically because PR #1669 was pushed to master and backport to ipa-4-5 is required.

@Rezney @tiran
test_caless: adjust try/except to capture also IOError
9097a85 
While testing on RHEL we are getting IOError instead of OSError.
Add also IOError to except clause.

This is mostly for compatibility reasons however should not cause
any issue as IOError is alias for OSError on Python3.

https://pagure.io/freeipa/issue/7439
@tiran
Copy link
Member Author

tiran commented Mar 14, 2018

PR was ACKed automatically because this is backport of PR #1669. Wait for CI to finish before pushing. In case of questions or problems contact @Rezney who is author of the original PR.

@tiran tiran added the ack Pull Request approved, can be merged label Mar 14, 2018
@tiran
Copy link
Member Author

tiran commented Mar 15, 2018

ipa-4-5:

  • dde9b26 test_caless: adjust try/except to capture also IOError

@tiran tiran added the pushed Pull Request has already been pushed label Mar 15, 2018
@tiran tiran closed this Mar 15, 2018
@tiran tiran deleted the backport_pr1669_ipa-4-5 branch March 29, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
2 participants
@tiran @Rezney