Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep owner when backing up CA.cfg #1693

Closed
wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Mar 15, 2018

Closes: https://pagure.io/freeipa/issue/7426
Signed-off-by: Christian Heimes cheimes@redhat.com

@tiran tiran added the re-run Trigger a new run of PR-CI label Mar 15, 2018
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Mar 15, 2018
@tiran tiran added the needs review Pull Request is waiting for a review label Mar 16, 2018
@slaykovsky
Copy link
Collaborator

Hi @tiran

Please update a commit message to include problem description and your solution.

Thanks.

DogtagInstance.backup_config uses shutil.copy to create a backup of the
config file. The function does not retain owner and group, so it creates a
backup as user and group root:root.

Closes: https://pagure.io/freeipa/issue/7426
Signed-off-by: Christian Heimes <cheimes@redhat.com>
@slaykovsky slaykovsky self-assigned this Mar 19, 2018
@slaykovsky slaykovsky added ack Pull Request approved, can be merged and removed needs review Pull Request is waiting for a review labels Mar 19, 2018
@tiran tiran added the pushed Pull Request has already been pushed label Mar 19, 2018
@tiran
Copy link
Member Author

tiran commented Mar 19, 2018

master:

  • 3871fe6 Keep owner when backing up CA.cfg

@tiran tiran closed this Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
3 participants