Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax message check in test_create_host_with_ip #1697

Closed
wants to merge 1 commit into from
Closed

Relax message check in test_create_host_with_ip #1697

wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Mar 16, 2018 •
edited

On Travis CI, the DNS update in test case test_create_host_with_ip may fail
with different error messages. Relax the error message check and just
check that the test case is hitting a DNS update failure.

This fixes a flaky test case on CI.

Closes: https://pagure.io/freeipa/issue/7447
Signed-off-by: Christian Heimes cheimes@redhat.com

@tiran
Relax message check in test_create_host_with_ip
fb21e4e 
On Travis CI, the DNS update in test case test_create_host_with_ip may fail
with different error messages. Relax the error message check and just
check that the test case is hitting a DNS update failure.

This fixes a flaky test case on CI.

Closes: https://pagure.io/freeipa/issue/7447
Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran tiran added the needs review Pull Request is waiting for a review label Mar 16, 2018
@tiran tiran requested a review from flo-renaud March 16, 2018 08:23
@flo-renaud
Copy link
Contributor

Hi @tiran
I'm just annoyed I still don't understand what is different in Travis-CI env that would explain the different error msgs (I'm not DNS-fluent unfortunately...)
But I agree the proposed modification will make the test green, so ACK as soon as the test results are available.

@abbra
Copy link
Contributor

abbra commented Mar 16, 2018

I agree. We are interested in seeing the first part of the message anyway.

@flo-renaud flo-renaud added ack Pull Request approved, can be merged and removed needs review Pull Request is waiting for a review labels Mar 16, 2018
@flo-renaud
Copy link
Contributor

Tests are green, giving ACK

@tiran tiran added the pushed Pull Request has already been pushed label Mar 16, 2018
@tiran
Copy link
Member Author

tiran commented Mar 16, 2018

master:

  • 6959956 Relax message check in test_create_host_with_ip

@tiran tiran closed this Mar 16, 2018
@tiran tiran mentioned this pull request Mar 16, 2018
Closed
@tiran tiran deleted the issue7447_create_host_with_ip branch March 19, 2018 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flo-renaud flo-renaud Awaiting requested review from flo-renaud

Assignees
No one assigned
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
3 participants
@tiran @flo-renaud @abbra