ctypes.util.find_library() replacement #1773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
requested changes
Apr 4, 2018
| logger.debug("Checking ldconfig output for: %s", name) | ||
| process = subprocess.Popen( | ||
| "ldconfig -N -p | awk '{print $1, $NF}' | grep '^lib%s\.so.*'" | ||
| % name, shell=True, stdout=subprocess.PIPE, |
There was a problem hiding this comment.
This code is slower and less secure than find_library from ctypes. You are executing at least four programs. find_library starts only one binary. shell=True is also a security issue and makes the code vulnerable to shell injection attacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
component: ipaclient/csrgen_ffi.py, ipaserver/p11helper.py, ipaplatform/redhat/tasks.py
Create a dumbed down replacement for ctypes.util.find_library().. parses ldconfig output
https://pagure.io/freeipa/issue/6851