Travis - use F28 for testing

[stlaz]

python2 pylint fails on Fedora 28 with errors about relative imports from ipapplatform that seem to be false-positives. Use only python3 pylint for Travis.

The Fedora 28 test-runner container in this commit is only to show that the tests pass, I'll update the Fedora 28 container in DockerHub FreeIPA repo once we agree on this PR.

[stlaz]

Note that on Rawhide, FreeIPA does not build due to (samba?) C API changes: https://travis-ci.org/stlaz/freeipa/builds/362337027

[tiran]

python2 pylint is passing for me on F28. If you run into relative import issues, then simply add from __future__ import absolute_import to the failing files.

[stlaz]

The issues are with so many files that I just did not find adding the import reasonable: https://travis-ci.org/stlaz/freeipa/jobs/362492712

[tiran]

For maximum compatibility with Python 3, all files should have the future import. Pylint is pointing out an actual issue. I raises the issue, when we started to migrate to Python 3. Back then, the rest of the time felt it wasn't necessary.

[stlaz]

I see. I'll add the imports, then.

[abbra]

The failure in https://travis-ci.org/stlaz/freeipa/jobs/362337028 is not due to Samba changes. Instead, pylint insists our executable is a python module:

internal error with sending report for module ['install/oddjob/com.redhat.idm.trust-fetch-domains']
'module' object has no attribute 'location'
AttributeError: 'module' object has no attribute 'location'

and then there is another set of errors from astroid:

************* Module ipaserver.dcerpc
ipaserver/dcerpc.py:1: [F0002(astroid-error), ] <type 'exceptions.AttributeError'>: 'module' object has no attribute 'location')
************* Module ipaserver.plugins.trust
ipaserver/plugins/trust.py:839: [E1101(no-member), trust_add.validate_options] Instance of 'TrustDomainJoins' has no 'configured' member)
ipaserver/plugins/trust.py:938: [E1101(no-member), trust_add.validate_range] Instance of 'TrustDomainJoins' has no 'remote_domain' member)
ipaserver/plugins/trust.py:1047: [E1101(no-member), trust_add.execute_ad] Instance of 'TrustDomainJoins' has no 'remote_domain' member)
ipaserver/plugins/trust.py:1067: [E1101(no-member), trust_add.execute_ad] Instance of 'TrustDomainJoins' has no 'remote_domain' member)

these may be valid ones, may be induced by some changes in the pylint infra.

[stlaz]

If you however look in https://travis-ci.org/stlaz/freeipa/jobs/362337032, you'll see the build is failing because of an incomplete type dereference (and a couple of other warnings):

  CC       ipa_sam.lo
ipa_sam.c: In function ‘_smbldap_get_ldap’:
ipa_sam.c:351:14: error: dereferencing pointer to incomplete type ‘struct smbldap_state’
  return state->ldap_struct;
              ^~
ipa_sam.c: In function ‘_smbldap_get_paged_results’:
ipa_sam.c:362:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
ipa_sam.c: In function ‘_smbldap_get_ldap’:
ipa_sam.c:354:1: warning: control reaches end of non-void function [-Wreturn-type]
 }

[abbra]

@stlaz there is something wrong with the build environment:

checking for pdb_enum_upn_suffixes in -lpdb... no
configure: WARNING: libpdb does not have pdb_enum_upn_suffixes, no support for realm domains in ipasam
checking for smbldap_get_ldap in -lsmbldap... no
configure: WARNING: libsmbldap is not opaque, not using smbldap_get_ldap
checking for smbldap_set_bind_callback in -lsmbldap... no
configure: WARNING: libsmbldap is not opaque, not using smbldap_set_bind_callback

The package it tried to use is samba-4.8.0-7.fc29 and that package has all required symbols. Unfortunately, I don't see config.log from travis build to understand why it failed to detect them.

[stlaz]

Pushed latest update with absolute imports.

[stlaz]

Either ACK or NACK in 24hrs please.

[abbra]

LGTM.

[stlaz]

master:

• b5bdd07 Add absolute_import future imports