New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding test-cases for ipa-cacert-manage #1849
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -484,6 +484,19 @@ def test_replica_not_marked_as_renewal_master(self): | |
"Replica hostname found among CA renewal masters" | ||
) | ||
|
||
def test_renewal_replica_with_ipa_ca_cert_manage(self): | ||
"""Make replica as IPA CA renewal master using | ||
ipa-cacert-manage --renew""" | ||
master = self.master | ||
replica = self.replicas[0] | ||
self.assertCARenewalMaster(master, master.hostname) | ||
replica.run_command([paths.IPA_CACERT_MANAGE, 'renew']) | ||
self.assertCARenewalMaster(replica, replica.hostname) | ||
# set master back to ca-renewal-master | ||
master.run_command([paths.IPA_CACERT_MANAGE, 'renew']) | ||
self.assertCARenewalMaster(master, master.hostname) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would also check how other server (replica in this case) sees the situation. So:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As per your suggestion, I have added check for replica also on line 498 |
||
self.assertCARenewalMaster(replica, master.hostname) | ||
|
||
def test_manual_renewal_master_transfer(self): | ||
replica = self.replicas[0] | ||
replica.run_command(['ipa', 'config-mod', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use PEP 8 / PEP 257 doc strings. You are missing an empty line after the headline. The other lines are not properly indented, too.
https://www.python.org/dev/peps/pep-0008/#documentation-strings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review.
I have added all changes requested by you.