[Backport][ipa-4-6] Check if issuer DN is updated after self-signed > external-ca #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrizwan93
changed the title
|
Pylint errors: Before you push a PR, please always run |
|
Backport of #2049 |
mrizwan93
force-pushed
the
backport-1518932-7-6
branch
from
adf3304
to
6330546
Compare
tiran
requested changes
Jun 25, 2018
|
@tiran Hi, we need to move but I am afraid if the path is used in other test suits. what you suggest? |
mrizwan93
force-pushed
the
backport-1518932-7-6
branch
from
6330546
to
560a773
Compare
|
my bad :( fixed. |
tiran
requested changes
Jun 26, 2018
| def create_ca(self, cn='example.test'): | ||
| def __init__(self, days=365): | ||
| self.now = datetime.datetime.utcnow() | ||
| self.delta = datetime.timedelta(days=days) |
There was a problem hiding this comment.
now and delta are not used in this branch. Please remove def __init__ again.
This test checks if issuer DN is updated properly after CA is renewed from self-signed to external-ca related ticket: https://pagure.io/freeipa/issue/7316 Signed-off-by: Mohammad Rizwan Yusuf <myusuf@redhat.com> Replaced hardcoded issuer CN for external ca with constant Signed-off-by: Mohammad Rizwan Yusuf <myusuf@redhat.com> Reviewed-By: Christian Heimes <cheimes@redhat.com> Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
mrizwan93
force-pushed
the
backport-1518932-7-6
branch
from
560a773
to
d3c01fe
Compare
tiran
approved these changes
Jun 26, 2018
|
ipa-4-6:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test checks if issuer DN is updated properly after CA is
renewed from self-signed to external-ca
related ticket: https://pagure.io/freeipa/issue/7316
Signed-off-by: Mohammad Rizwan Yusuf myusuf@redhat.com
Replaced hardcoded issuer CN for external ca with constant
Signed-off-by: Mohammad Rizwan Yusuf myusuf@redhat.com
Reviewed-By: Christian Heimes cheimes@redhat.com
Reviewed-By: Florence Blanc-Renaud frenaud@redhat.com