Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport][ipa-4-5] Check if issuer DN is updated after self-signed > external-ca #2064

Closed
wants to merge 1 commit into from
Closed

[Backport][ipa-4-5] Check if issuer DN is updated after self-signed > external-ca #2064

wants to merge 1 commit into from

Conversation

mrizwan93
Copy link
Contributor

@mrizwan93 mrizwan93 commented Jun 25, 2018 •
edited by Tiboris

This test checks if issuer DN is updated properly after CA is
renewed from self-signed to external-ca

related ticket: https://pagure.io/freeipa/issue/7316

Signed-off-by: Mohammad Rizwan Yusuf myusuf@redhat.com

Replaced hardcoded issuer CN for external ca with constant

Signed-off-by: Mohammad Rizwan Yusuf myusuf@redhat.com
Reviewed-By: Christian Heimes cheimes@redhat.com
Reviewed-By: Florence Blanc-Renaud frenaud@redhat.com

@tiran
Copy link
Member

tiran commented Jun 25, 2018

Pylint fails:

************* Module ipatests.test_integration.test_external_ca
ipatests/test_integration/test_external_ca.py:26: [E0611(no-name-in-module), ] No name 'create_external_ca' in module 'ipatests')
ipatests/test_integration/test_external_ca.py:26: [E0401(import-error), ] Unable to import 'ipatests.create_external_ca')
ipatests/test_integration/test_external_ca.py:26: [W0611(unused-import), ] Unused ExternalCA imported from ipatests.create_external_ca)
Makefile:1165: recipe for target 'pylint' failed

@Tiboris
Copy link
Member

Tiboris commented Jun 25, 2018

Backport of #2049

@mrizwan93
Check if issuer DN is updated after self-signed > external-ca
6469f79 
This test checks if issuer DN is updated properly after CA is
renewed from self-signed to external-ca

related ticket: https://pagure.io/freeipa/issue/7316

Signed-off-by: Mohammad Rizwan Yusuf <myusuf@redhat.com>

Replaced hardcoded issuer CN for external ca with constant

Signed-off-by: Mohammad Rizwan Yusuf <myusuf@redhat.com>
Reviewed-By: Christian Heimes <cheimes@redhat.com>
Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
@Tiboris Tiboris added the ack Pull Request approved, can be merged label Jun 25, 2018
@Tiboris
Copy link
Member

Tiboris commented Jun 26, 2018

ipa-4-5:

  • 13037e6 Check if issuer DN is updated after self-signed > external-ca

@Tiboris Tiboris added the pushed Pull Request has already been pushed label Jun 26, 2018
@Tiboris Tiboris closed this Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
3 participants
@mrizwan93 @tiran @Tiboris