Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][ipa-4-6] Add tab completion and history to ipa console #2148

Closed
wants to merge 3 commits into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Jul 12, 2018

This PR was opened automatically because PR #2140 was pushed to master and backport to ipa-4-6 is required.

ipa console is a useful tool to use FreeIPA's API in an interactive
Python console. The patch adds readline tab completion and history
support.

Signed-off-by: Christian Heimes <cheimes@redhat.com>
upload_temp_contents() generates a temporary file on the remote side and
uploads content to that temporary file. The file name is returned.

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran tiran added the ack Pull Request approved, can be merged label Jul 12, 2018
@tiran
Copy link
Member Author

tiran commented Jul 12, 2018

PR was ACKed automatically because this is backport of PR #2140. Wait for CI to finish before pushing. In case of questions or problems contact @tiran who is author of the original PR.

THe ipa console command takes an optional filename argument. The
filename argument was broken, because the implementation passed a file
object to exec() instead of a string or compiled object.

ipa console now uses compile() to compile the code with print_function
__future__ feature.

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran tiran added the pushed Pull Request has already been pushed label Jul 13, 2018
@tiran
Copy link
Member Author

tiran commented Jul 13, 2018

ipa-4-6:

  • a1a87f9 Add tab completion and history to ipa console
  • cfba669 Create helper function to upload to temp file
  • 7af4528 Fix ipa console filename

@tiran tiran closed this Jul 13, 2018
@tiran tiran deleted the backport_pr2140_ipa-4-6 branch March 29, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
1 participant