New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix script loading errors in ssbrowser.html and unauthorized.html #2383
Conversation
So the fix was just to move the javascript out of the html file? Can you describe the reasoning for the fix in the commit message? |
Hello, @serg-cymbaluk Please take a look at last commit: It completely fixes the issue. |
We can't import modules in HTML-file because it requires js file in the runtime. But when we import module from other module this dependency is resolved in compile-time. |
@stanislavlevin, please create new PR if it is final edits. |
#2387 opened. |
@stanislavlevin This PR needs rebase, too. |
It does not belong to me ;-) About this PR, in my opinion, it is no longer needed. |
Sorry @stanislavlevin @serg-cymbalu, what about this PR? Is it still necessary? |
It is already not actual. |
Related issue: https://pagure.io/freeipa/issue/7703