Added automation for NTP options test scenarios #2404

varunmylaraiah · 2018-09-27T09:08:17Z

ipatests: add tests for NTP options usage on server, replica, and client

The following tests are added in test_ntp_options.py :: TestNTPoptions
  - test_server_and_client_install_without_option_n
  - test_server_and_client_install_with_option_n
  - test_server_and_client_install_with_multiple_ntp_server
  - test_server_replica_and_client_install_with_ntp_pool_and_ntp_server
  - test_server_and_client_install_with_mixed_options
  - test_two_step_replica_install_using_ntp_options
  - test_two_step_replica_install_without_ntp_options

Details in the ticket: https://pagure.io/freeipa/issue/7719
and https://pagure.io/freeipa/issue/7723

flo-renaud · 2018-09-27T11:09:53Z

Hi @varunmylaraiah
thanks for the PR. Please fix pylint error:
ipatests/test_integration/test_ntp_replacement.py:5: [W0611(unused-import), ] Unused import pytest

rcritten · 2018-09-27T17:51:04Z

ipatests/test_integration/test_ntp_replacement.py

+        assert "%s" % ntp_pool in cmd.stdout_text
+        tasks.uninstall_master(self.master)
+
+    def test_server_install_with_multiple_ntp_server(self):


nit: typo, s/potion/option

rcritten · 2018-09-27T17:55:47Z

Did you want to add this to nightly_rawhide.yaml as well?

Do you plan on negative testing as well? Things like:

Mixing -N with --ntp-pool or ntp-server
If no ntp server is provided on the cli then DNS discovery will be used to try to find one (might be hard/impossible to make generic)
Setting both pools and networks (may be pointless but could prevent regressions)

flo-renaud

Hi @varunmylaraiah
Can you fix the test definition? The small error has crashed PRCI. Thanks

flo-renaud · 2018-09-28T10:03:43Z

ipatests/prci_definitions/gating.yaml

+        test_suite: test_integration/test_ntp_replacement.py::TestNTPreplacement
+        template: *ci-master-f28
+        timeout: 7200
+        topology: master_1repl_1client


This should be topology: *master_1repl_1client

flo-renaud · 2018-09-28T10:03:54Z

ipatests/prci_definitions/nightly_master.yaml

+        test_suite: test_integration/test_ntp_replacement.py::TestNTPreplacement
+        template: *ci-master-f28
+        timeout: 7200
+        topology: master_1repl_1client 


This should be topology: *master_1repl_1client

flo-renaud · 2018-09-28T10:15:53Z

I am setting the postponed label so that this PR does not get picked by PRCI and does not crash the prci process. You can remove the label as soon as the test definition is fixed.

varunmylaraiah · 2018-09-28T14:02:20Z

Did you want to add this to nightly_rawhide.yaml as well?

Do you plan on negative testing as well? Things like:

Mixing -N with --ntp-pool or ntp-server

If no ntp server is provided on the cli then DNS discovery will be used to try to find one (might be hard/impossible to make generic)

Setting both pools and networks (may be pointless but could prevent regressions)

Thank you for the Review,
Yes, I am trying to add negative scenarios along with Replica and client test cases.

varunmylaraiah · 2018-09-28T14:03:22Z

I am setting the postponed label so that this PR does not get picked by PRCI and does not crash the prci process. You can remove the label as soon as the test definition is fixed.

Thanks, Flo, Will fix the issue.

ipatests/test_integration/test_ntp_replacement.py

ipatests/prci_definitions/gating.yaml

ipatests/test_integration/test_ntp_replacement.py

Tiboris

Hi @varunmylaraiah,

What looks very bad to me is long method names (i did not looked at it before so, sorry).
In fact names of methods could be shorter and doc string will tell us what they are meant to do.
In this case, please see also some doc string suggestions.

Thanks for patience!

ipatests/prci_definitions/nightly_master.yaml

ipatests/test_integration/test_ntp_options.py

The following tests are added in test_ntp_options.py :: TestNTPoptions - test_server_and_client_install_without_option_n - test_server_and_client_install_with_option_n - test_server_and_client_install_with_multiple_ntp_server - test_server_replica_and_client_install_with_ntp_pool_and_ntp_server - test_server_and_client_install_with_mixed_options - test_two_step_replica_install_using_ntp_options - test_two_step_replica_install_without_ntp_options Details in the ticket: https://pagure.io/freeipa/issue/7719 and https://pagure.io/freeipa/issue/7723 Signed-off-by: Varun Mylaraiah <mvarun@redhat.com>

Added test_integration/test_ntp_options.py Signed-off-by: Varun Mylaraiah <mavrun@redhat.com>

Added test_integration/test_ntp_options.py Signed-off-by: Varun Mylaraiah <mvarun@redhat.com>

All requested changes adressed

Tiboris · 2018-12-03T11:50:28Z

Could you please remove Temp commit?

Tiboris · 2018-12-03T12:59:36Z

master:

dde2aa4 ipatests: add tests for NTP options usage on server, replica, and client
715d122 nightly_master.yaml Added test_integration/test_ntp_options.py
83487c4 nightly_rawhide.yaml Added test_integration/test_ntp_options.py

varunmylaraiah force-pushed the ntp_replacement branch from 61cdeb1 to 55967ca Compare September 27, 2018 13:31

rcritten reviewed Sep 27, 2018

View reviewed changes

flo-renaud reviewed Sep 28, 2018

View reviewed changes

flo-renaud added WIP Work in progress - not ready yet for review postponed labels Sep 28, 2018

varunmylaraiah force-pushed the ntp_replacement branch from 55967ca to c6842b9 Compare September 28, 2018 14:22

varunmylaraiah removed the postponed label Sep 28, 2018

stanislavlevin reviewed Oct 1, 2018

View reviewed changes

ipatests/test_integration/test_ntp_replacement.py Outdated Show resolved Hide resolved

tiran requested changes Oct 1, 2018

View reviewed changes

varunmylaraiah force-pushed the ntp_replacement branch 2 times, most recently from 23f5b02 to 6ffab80 Compare October 8, 2018 10:11

varunmylaraiah removed the WIP Work in progress - not ready yet for review label Oct 9, 2018

varunmylaraiah assigned varunmylaraiah and unassigned varunmylaraiah Oct 9, 2018

varunmylaraiah added the re-run Trigger a new run of PR-CI label Oct 9, 2018

freeipa-pr-ci removed re-run Trigger a new run of PR-CI labels Oct 9, 2018

varunmylaraiah added the re-run Trigger a new run of PR-CI label Oct 9, 2018

freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Oct 9, 2018

varunmylaraiah force-pushed the ntp_replacement branch from 6ffab80 to 4bb2a9c Compare October 9, 2018 10:53

varunmylaraiah added the re-run Trigger a new run of PR-CI label Oct 9, 2018

freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Oct 9, 2018

tiran added the needs review Pull Request is waiting for a review label Oct 15, 2018

tiran previously requested changes Oct 15, 2018

View reviewed changes

tiran added the WIP Work in progress - not ready yet for review label Oct 15, 2018

varunmylaraiah force-pushed the ntp_replacement branch from 62ae309 to 6f7b703 Compare November 30, 2018 11:17

Tiboris removed the needs rebase Pull Request cannot be automatically merged - needs to be rebased label Nov 30, 2018

varunmylaraiah added the re-run Trigger a new run of PR-CI label Dec 3, 2018

freeipa-pr-ci removed re-run Trigger a new run of PR-CI labels Dec 3, 2018

varunmylaraiah force-pushed the ntp_replacement branch from 6f7b703 to 3d95f9b Compare December 3, 2018 06:29

Tiboris requested changes Dec 3, 2018

View reviewed changes

varunmylaraiah force-pushed the ntp_replacement branch from 3d95f9b to 2ead00f Compare December 3, 2018 09:50

varunmylaraiah added 3 commits December 3, 2018 15:28

nightly_master.yaml

63dfa50

Added test_integration/test_ntp_options.py Signed-off-by: Varun Mylaraiah <mavrun@redhat.com>

nightly_rawhide.yaml

87bba22

Added test_integration/test_ntp_options.py Signed-off-by: Varun Mylaraiah <mvarun@redhat.com>

varunmylaraiah force-pushed the ntp_replacement branch from 2ead00f to 1b750a5 Compare December 3, 2018 09:58

Tiboris added ipa-4-7 and removed WIP Work in progress - not ready yet for review labels Dec 3, 2018

varunmylaraiah force-pushed the ntp_replacement branch from 1b750a5 to 87bba22 Compare December 3, 2018 11:53

Tiboris added ack Pull Request approved, can be merged pushed Pull Request has already been pushed labels Dec 3, 2018

Tiboris closed this Dec 3, 2018

This was referenced Dec 3, 2018

[Backport][ipa-4-7] Added automation for NTP options test scenarios #2635

Closed

Fix test_ntp_options #2638

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added automation for NTP options test scenarios #2404

Added automation for NTP options test scenarios #2404

varunmylaraiah commented Sep 27, 2018 •

edited

flo-renaud commented Sep 27, 2018

rcritten Sep 27, 2018

rcritten commented Sep 27, 2018

flo-renaud left a comment

flo-renaud Sep 28, 2018

flo-renaud Sep 28, 2018

varunmylaraiah Oct 4, 2018

flo-renaud commented Sep 28, 2018

varunmylaraiah commented Sep 28, 2018

varunmylaraiah commented Sep 28, 2018

Tiboris left a comment •

edited

Tiboris commented Dec 3, 2018

Tiboris commented Dec 3, 2018

Added automation for NTP options test scenarios #2404

Added automation for NTP options test scenarios #2404

Conversation

varunmylaraiah commented Sep 27, 2018 • edited

flo-renaud commented Sep 27, 2018

rcritten Sep 27, 2018

Choose a reason for hiding this comment

rcritten commented Sep 27, 2018

flo-renaud left a comment

Choose a reason for hiding this comment

flo-renaud Sep 28, 2018

Choose a reason for hiding this comment

flo-renaud Sep 28, 2018

Choose a reason for hiding this comment

varunmylaraiah Oct 4, 2018

Choose a reason for hiding this comment

flo-renaud commented Sep 28, 2018

varunmylaraiah commented Sep 28, 2018

varunmylaraiah commented Sep 28, 2018

Tiboris left a comment • edited

Choose a reason for hiding this comment

Tiboris commented Dec 3, 2018

Tiboris commented Dec 3, 2018

varunmylaraiah commented Sep 27, 2018 •

edited

Tiboris left a comment •

edited