Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][ipa-4-6] Find orphan automember rules #2444

Closed

Conversation

t-woerner
Copy link
Member

This is a manual backport of PR #2413 to ipa-4-6 branch.

If groups or hostgroups have been removed after automember rules have been
created using them, then automember-rebuild, automember-add, host-add and
more commands could fail.

A new command has been added to the ipa tool:

  ipa automember-find-orphans --type={hostgroup,group} [--remove]

This command retuns the list of orphan automember rules in the same way as
automember-find. With the --remove option the orphan rules are also removed.

The IPA API version has been increased and a test case has been added.

Using ideas from a patch by: Rob Crittenden <rcritten@redhat.com>

See: https://pagure.io/freeipa/issue/6476
Signed-off-by: Thomas Woerner <twoerner@redhat.com>
Reviewed-By: Christian Heimes <cheimes@redhat.com>
Reviewed-By: Florence Blanc-Renaud <flo@redhat.com>
@t-woerner t-woerner added the re-run Trigger a new run of PR-CI label Oct 10, 2018
@freeipa-pr-ci freeipa-pr-ci removed re-run Trigger a new run of PR-CI labels Oct 10, 2018
@flo-renaud flo-renaud self-assigned this Oct 11, 2018
@flo-renaud flo-renaud added the ack Pull Request approved, can be merged label Oct 11, 2018
@flo-renaud
Copy link
Contributor

LGTM

@flo-renaud
Copy link
Contributor

ipa-4-6:

  • 890b8aa Find orphan automember rules

@flo-renaud flo-renaud added the pushed Pull Request has already been pushed label Oct 12, 2018
@flo-renaud flo-renaud closed this Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
3 participants