ipa-replica-install --setup-adtrust: check for package ipa-server-tru… #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flo-renaud
added
ipa-4-7
ipa-4-6
|
ACK |
|
Travis builds are failing now due to https://bugzilla.redhat.com/show_bug.cgi?id=1574478 |
abbra
added
ack
|
rerun, |
…st-ad When adding the option --setup-adtrust to ipa-replica-install, we need to check that the package freeipa-server-trust-ad is installed. To avoid relying on OS-specific commands like yum, the check is instead ensuring that the file /usr/share/ipa/smb.conf.empty is present (this file is delivered by the package). When the check is unsuccessful, ipa-replica-install exits with an error message. Fixes: https://pagure.io/freeipa/issue/7602
|
Rebased to master to pick the annobin fix. |
|
master:
|
This was referenced Oct 24, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…st-ad
When adding the option --setup-adtrust to ipa-replica-install,
we need to check that the package freeipa-server-trust-ad is
installed.
To avoid relying on OS-specific commands like yum, the check is instead
ensuring that the file /usr/share/ipa/smb.conf.empty is present
(this file is delivered by the package).
When the check is unsuccessful, ipa-replica-install exits with an error
message.
Fixes: https://pagure.io/freeipa/issue/7602