Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][ipa-4-7] Copy-paste error in permssions plugin, CID 323649 #2536

Closed
wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Nov 8, 2018

This PR was opened automatically because PR #2535 was pushed to master and backport to ipa-4-7 is required.

Address a bug in the code block for attributeLevelRights for old clients.
The backward compatibility code for deprecated options was not triggered,
because the new name was checked against wrong dict.

Coverity Scan issue 323649, Copy-paste error

   The copied code will not have its intended effect.
   In postprocess_result: A copied piece of code is inconsistent with the
   original (CWE-398)

See: Fixes: https://pagure.io/freeipa/issue/7753
Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran
Copy link
Member Author

tiran commented Nov 8, 2018

PR was ACKed automatically because this is backport of PR #2535. Wait for CI to finish before pushing. In case of questions or problems contact @tiran who is author of the original PR.

@tiran tiran added ack Pull Request approved, can be merged pushed Pull Request has already been pushed labels Nov 8, 2018
@tiran
Copy link
Member Author

tiran commented Nov 8, 2018

ipa-4-7:

  • 48a6048 Copy-paste error in permssions plugin, CID 323649

@tiran tiran closed this Nov 8, 2018
@tiran tiran deleted the backport_pr2535_ipa-4-7 branch March 29, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
1 participant