Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipatests: add missing nightly tests for replica_promotion installation and external_ca #2563

Closed
wants to merge 3 commits into from

Conversation

flo-renaud
Copy link
Contributor

ipatests: add missing tests for test_installation.py

Some tests were missing in the nightly:

  • test_installation.py::TestInstallWithCA_DNS3
  • test_installation.py::TestInstallWithCA_DNS4

ipatests: add missing tests for test_replica_promotion.py

The following test was missing from nightly:
test_replica_promotion.py::TestReplicaInstallCustodia

ipatests: add missing tests for test_external_ca.py

Some tests were missing from nightly definition:

  • test_external_ca.py::TestExternalCAdirsrvStop
  • test_external_ca.py::TestExternalCAInvalidCert
  • test_external_ca.py::TestMultipleExternalCA

Related to https://pagure.io/freeipa/issue/7743

Some tests were missing from nightly definition:
test_external_ca.py::TestExternalCAdirsrvStop
test_external_ca.py::TestExternalCAInvalidCert
test_external_ca.py::TestMultipleExternalCA

Related to https://pagure.io/freeipa/issue/7743
Some tests were missing in the nightly:
- test_installation.py::TestInstallWithCA_DNS3
- test_installation.py::TestInstallWithCA_DNS4

Relates to https://pagure.io/freeipa/issue/7743
The following test was missing from nightly:
test_replica_promotion.py::TestReplicaInstallCustodia

Related to https://pagure.io/freeipa/issue/7743
@flo-renaud flo-renaud added needs review Pull Request is waiting for a review ipa-next Mark as master (4.12) only labels Nov 14, 2018
@abbra
Copy link
Contributor

abbra commented Nov 14, 2018

Looks good. Please remove temp commit.

@abbra abbra removed the needs review Pull Request is waiting for a review label Nov 14, 2018
@flo-renaud
Copy link
Contributor Author

Thanks, temp commit removed

@abbra
Copy link
Contributor

abbra commented Nov 14, 2018

Both travis and PR-CI encountered networking issues with fedora repositories. Re-starting the run.

@abbra abbra added the re-run Trigger a new run of PR-CI label Nov 14, 2018
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Nov 14, 2018
@tiran tiran added the ack Pull Request approved, can be merged label Nov 20, 2018
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alexander already reviewed the PR. Changes LGTM 👍

@flo-renaud flo-renaud added the pushed Pull Request has already been pushed label Nov 21, 2018
@flo-renaud
Copy link
Contributor Author

master:

  • 1e7be6f ipatests: add missing tests for test_external_ca.py
  • 1921125 ipatests: add missing tests for test_installation.py
  • d18b0d5 ipatests: add missing tests for test_replica_promotion.py

@flo-renaud flo-renaud closed this Nov 21, 2018
@flo-renaud flo-renaud deleted the add_extca_tests branch November 21, 2018 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged ipa-next Mark as master (4.12) only pushed Pull Request has already been pushed
Projects
None yet
4 participants