Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ipa-4-6] too-restrictive mask checks #2894

Closed
wants to merge 2 commits into from
Closed

[ipa-4-6] too-restrictive mask checks #2894

wants to merge 2 commits into from

Conversation

fcami
Copy link
Contributor

@fcami fcami commented Mar 13, 2019

MANUAL BACKPORT

ipatests: add too-restritive mask tests
ipa-{server,replica}-install: add too-restritive mask detection

If the mask used during the installation is "too restrictive", ie.0027,
installing FreeIPA results in a broken server or replica.
Check for too-restrictive mask at install time and error out.

Fixes: https://pagure.io/freeipa/issue/7193
Signed-off-by: François Cami fcami@redhat.com

If the mask used during the installation is "too restrictive", ie.0027,
installing FreeIPA results in a broken server or replica.
Add two tests that expect an error message at install time to catch
too restrictive masks.

Related to: https://pagure.io/freeipa/issue/7193
Signed-off-by: François Cami <fcami@redhat.com>
Reviewed-By: Florence Blanc-Renaud <flo@redhat.com>
If the mask used during the installation is "too restrictive", ie.0027,
installing FreeIPA results in a broken server or replica.
Check for too-restrictive mask at install time and error out.

Fixes: https://pagure.io/freeipa/issue/7193
Signed-off-by: François Cami <fcami@redhat.com>
Reviewed-By: Florence Blanc-Renaud <flo@redhat.com>
@fcami fcami added the needs review Pull Request is waiting for a review label Mar 13, 2019
@flo-renaud flo-renaud self-assigned this Mar 14, 2019
@flo-renaud
Copy link
Contributor

Hi @fcami
thanks for the backport, WFH. Same tests as on ipa-4-7 branch, ie installation of server/replica with umask 027, properly refused, and installation with umask 022, properly succeeding.

@flo-renaud flo-renaud added ack Pull Request approved, can be merged pushed Pull Request has already been pushed and removed needs review Pull Request is waiting for a review labels Mar 14, 2019
@flo-renaud
Copy link
Contributor

ipa-4-6:

  • d37afbc ipatests: add too-restritive mask tests
  • c6e6a7a ipa-{server,replica}-install: add too-restritive mask detection

@flo-renaud flo-renaud closed this Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
2 participants